Added blank_value? to size predicate #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 19, 2015 14:58
Now, the application will ignore blank values for `size` predicate as well occurs for other predicates i.e. presence. The only exceptional case down to Enumerable implementations which if defined will be treated as filled value, as in examples below: ```ruby class AwesomeValidator attribute :name, type: String, size: 8..10 attribute :tags, type: Array, size: 2..10 end AwesomeValidator.new().valid? # < true AwesomeValidator.new(name: '12345678', tags: '').valid? # < true AwesomeValidator.new(tags: ['a', 'b']).valid? # < true AwesomeValidator.new(name: nil).valid? # < true AwesomeValidator.new(name: 'ooo').valid? # < false AwesomeValidator.new(tags: []).valid? # < false AwesomeValidator.new(tags: []).valid? # < false AwesomeValidator.new(name: 'abc', tags: []).valid? # < false ``` @solnic [has argued about](#80 (comment)) Conditional Validations and 'magical' validations/coercions which may introduce more complexity into this kind of issue. Closes #81
|
|
||
| Person.new.valid? # < true | ||
| Person.new(name: '').valid? # < true | ||
| Person.new(email: '@').valid? # < true |
There was a problem hiding this comment.
is this example valid? "@" isn't blank
There was a problem hiding this comment.
You're right. By a mistaken, I've thought one thing and did another totally different. Good catch! Thanks 👍
|
@hlegius Thank you, merging this. 👍 |
jodosha
added a commit
that referenced
this pull request
Nov 26, 2015
…te-fails Added blank_value? to size predicate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request added the ability to ignore blank values for
sizepredicate as well occurs for other predicates i.e. presence.The only exceptional case down to Enumerable's implementations which if defined will be treated as value as it is. i.e:
@solnic has argued about Conditional Validations and 'magical' validations/coercions which may introduce more complexity into this kind of issue. Maybe it worth more discussion later /cc @jodosha
Closes #81